Skip to content

Add some tests for HeaderMap, Authority, PathAndQuery, and Uri #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cppbear
Copy link

@cppbear cppbear commented May 24, 2025

Hi team,

This pull request adds a suite of new tests aimed at improving the test coverage within the repository.

The primary focus of these tests is on the HeaderMap, Authority, PathAndQuery, and Uri. We've ensured these tests are robust and cover key scenarios.

We appreciate your time in reviewing these additions.

Thanks.

@seanmonstar
Copy link
Member

Hey there! Looking at the test additions, it doesn't appear to add much that hasn't been tested already. If they do, it's not obvious by the naming that it is testing any new behavior.

I remember you said in your first contribution that you're using LLM/AI to generate code. While I have no policy forbidding AI, and don't mind it being used to generate something (such as repetitive things), I do need whatever has been generated to have been thoroughly considered if it is a value-add. Ask yourself questions about whether any new code is helpful, and if so, adjust it so that the value is easy to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants